Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread shashi . mallela
On Tue, 2021-07-06 at 14:27 +0100, Peter Maydell wrote: > On Tue, 6 Jul 2021 at 13:46, wrote: > > On Tue, 2021-07-06 at 10:19 +0100, Peter Maydell wrote: > > > On Tue, 6 Jul 2021 at 04:25, wrote: > > > > > > But the pseudocode for MAPTI does not say anywhere that we should > > > be checking the

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread shashi . mallela
On Tue, 2021-07-06 at 11:27 +0200, Eric Auger wrote: > Hi, > > On 7/5/21 4:07 PM, Peter Maydell wrote: > > On Wed, 30 Jun 2021 at 16:32, Shashi Mallela < > > shashi.mall...@linaro.org> wrote: > > > Added ITS command queue handling for MAPTI,MAPI commands,handled > > > ITS > > > translation which t

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread Peter Maydell
On Tue, 6 Jul 2021 at 13:46, wrote: > > On Tue, 2021-07-06 at 10:19 +0100, Peter Maydell wrote: > > On Tue, 6 Jul 2021 at 04:25, wrote: > > > > But the pseudocode for MAPTI does not say anywhere that we should > > be checking the pIntID against any CPU's GICR_PROPBASER field. > > It is checked on

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread shashi . mallela
On Tue, 2021-07-06 at 10:19 +0100, Peter Maydell wrote: > On Tue, 6 Jul 2021 at 04:25, wrote: > > On Mon, 2021-07-05 at 20:47 -0400, shashi.mall...@linaro.org wrote: > > > On Mon, 2021-07-05 at 15:54 +0100, Peter Maydell wrote: > > > > I missed this the first time around, but I don't think this is

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread Peter Maydell
On Tue, 6 Jul 2021 at 11:04, Eric Auger wrote: > > Hi Shashi, Peter, > > On 7/6/21 5:25 AM, shashi.mall...@linaro.org wrote: > > On Mon, 2021-07-05 at 20:47 -0400, shashi.mall...@linaro.org wrote: > >> On Mon, 2021-07-05 at 15:54 +0100, Peter Maydell wrote: > >>> I missed this the first time aroun

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread Eric Auger
Hi Shashi, On 6/30/21 5:31 PM, Shashi Mallela wrote: > Added ITS command queue handling for MAPTI,MAPI commands,handled ITS > translation which triggers an LPI via INT command as well as write > to GITS_TRANSLATER register,defined enum to differentiate between ITS > command interrupt trigger and GI

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread Eric Auger
Hi Shashi, Peter, On 7/6/21 5:25 AM, shashi.mall...@linaro.org wrote: > On Mon, 2021-07-05 at 20:47 -0400, shashi.mall...@linaro.org wrote: >> On Mon, 2021-07-05 at 15:54 +0100, Peter Maydell wrote: >>> On Wed, 30 Jun 2021 at 16:32, Shashi Mallela < >>> shashi.mall...@linaro.org> wrote: Added

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread Eric Auger
Hi, On 7/5/21 4:07 PM, Peter Maydell wrote: > On Wed, 30 Jun 2021 at 16:32, Shashi Mallela > wrote: >> >> Added ITS command queue handling for MAPTI,MAPI commands,handled ITS >> translation which triggers an LPI via INT command as well as write >> to GITS_TRANSLATER register,defined enum to diff

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread Peter Maydell
On Tue, 6 Jul 2021 at 04:25, wrote: > > On Mon, 2021-07-05 at 20:47 -0400, shashi.mall...@linaro.org wrote: > > On Mon, 2021-07-05 at 15:54 +0100, Peter Maydell wrote: > > > I missed this the first time around, but I don't think this is > > > right. > > > Different CPUs could have different GICR_P

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-05 Thread shashi . mallela
On Mon, 2021-07-05 at 20:47 -0400, shashi.mall...@linaro.org wrote: > On Mon, 2021-07-05 at 15:54 +0100, Peter Maydell wrote: > > On Wed, 30 Jun 2021 at 16:32, Shashi Mallela < > > shashi.mall...@linaro.org> wrote: > > > Added ITS command queue handling for MAPTI,MAPI commands,handled > > > ITS > >

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-05 Thread shashi . mallela
On Mon, 2021-07-05 at 15:54 +0100, Peter Maydell wrote: > On Wed, 30 Jun 2021 at 16:32, Shashi Mallela < > shashi.mall...@linaro.org> wrote: > > Added ITS command queue handling for MAPTI,MAPI commands,handled > > ITS > > translation which triggers an LPI via INT command as well as write > > to GIT

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-05 Thread Peter Maydell
On Wed, 30 Jun 2021 at 16:32, Shashi Mallela wrote: > > Added ITS command queue handling for MAPTI,MAPI commands,handled ITS > translation which triggers an LPI via INT command as well as write > to GITS_TRANSLATER register,defined enum to differentiate between ITS > command interrupt trigger and

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-05 Thread Peter Maydell
On Wed, 30 Jun 2021 at 16:32, Shashi Mallela wrote: > > Added ITS command queue handling for MAPTI,MAPI commands,handled ITS > translation which triggers an LPI via INT command as well as write > to GITS_TRANSLATER register,defined enum to differentiate between ITS > command interrupt trigger and

[PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-06-30 Thread Shashi Mallela
Added ITS command queue handling for MAPTI,MAPI commands,handled ITS translation which triggers an LPI via INT command as well as write to GITS_TRANSLATER register,defined enum to differentiate between ITS command interrupt trigger and GITS_TRANSLATER based interrupt trigger. Each of these commands