On Tue, 6 Jul 2021 at 11:04, Eric Auger <eau...@redhat.com> wrote: > > Hi Shashi, Peter, > > On 7/6/21 5:25 AM, shashi.mall...@linaro.org wrote: > > On Mon, 2021-07-05 at 20:47 -0400, shashi.mall...@linaro.org wrote: > >> On Mon, 2021-07-05 at 15:54 +0100, Peter Maydell wrote: > >>> I missed this the first time around, but I don't think this is > >>> right. > >>> Different CPUs could have different GICR_PROPBASER values, so > >>> checking > >>> against just one of them is wrong. > > "5.1.1 LPI configuration tables" says > > " > It is IMPLEMENTATION DEFINED whether GICR_PROPBASER can be set to > different values on different > Redistributors. GICR_TYPER.CommonLPIAff indicates which Redistributors > must have GICR_PROPBASER set > to the same value whenever GICR_CTLR.EnableLPIs == 1. > " > > So we can choose to set CommonLPIAff to 0 if we do not need to emulate > everything. This is what KVM does
We could choose to do that, but as it happens we don't. And as far as I can tell from the spec we should not be looking at GICR_PROPBASER at all here anyway. thanks -- PMM
