Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-20 Thread Yong Huang
On Tue, Feb 20, 2024 at 5:47 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster > wrote: > > > >> Yong Huang writes: > >> > >> > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster > >> wrote: > >> > > >> >> yong.hu...@smartx.com writes: > >

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-20 Thread Markus Armbruster
Yong Huang writes: > On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster wrote: > >> Yong Huang writes: >> >> > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster >> wrote: >> > >> >> yong.hu...@smartx.com writes: >> >> >> >> > From: Hyman Huang >> >> > >> >> > To support detached LUKS header cr

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-20 Thread Yong Huang
On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster > wrote: > > > >> yong.hu...@smartx.com writes: > >> > >> > From: Hyman Huang > >> > > >> > To support detached LUKS header creation, make the existing 'file' >

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-20 Thread Markus Armbruster
Yong Huang writes: > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster wrote: > >> yong.hu...@smartx.com writes: >> >> > From: Hyman Huang >> > >> > To support detached LUKS header creation, make the existing 'file' >> > field in BlockdevCreateOptionsLUKS optional. >> > >> > Signed-off-by: Hyma

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-19 Thread Yong Huang
On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster wrote: > yong.hu...@smartx.com writes: > > > From: Hyman Huang > > > > To support detached LUKS header creation, make the existing 'file' > > field in BlockdevCreateOptionsLUKS optional. > > > > Signed-off-by: Hyman Huang > > Reviewed-by: Daniel

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-19 Thread Markus Armbruster
yong.hu...@smartx.com writes: > From: Hyman Huang > > To support detached LUKS header creation, make the existing 'file' > field in BlockdevCreateOptionsLUKS optional. > > Signed-off-by: Hyman Huang > Reviewed-by: Daniel P. Berrangé [...] > diff --git a/qapi/block-core.json b/qapi/block-core.

[PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-01-29 Thread yong . huang
From: Hyman Huang To support detached LUKS header creation, make the existing 'file' field in BlockdevCreateOptionsLUKS optional. Signed-off-by: Hyman Huang Reviewed-by: Daniel P. Berrangé --- block/crypto.c | 21 ++--- qapi/block-core.json | 5 +++-- 2 files changed, 1