yong.hu...@smartx.com writes:
> From: Hyman Huang <yong.hu...@smartx.com>
>
> To support detached LUKS header creation, make the existing 'file'
> field in BlockdevCreateOptionsLUKS optional.
>
> Signed-off-by: Hyman Huang <yong.hu...@smartx.com>
> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ae604c6019..69a88d613d 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4957,7 +4957,8 @@
> #
> # Driver specific image creation options for LUKS.
> #
> -# @file: Node to create the image format on
> +# @file: Node to create the image format on, mandatory except when
> +# 'preallocation' is not requested
You mean when @preallocation is "off"?
Cases:
1. @file is mandatory
2. @file is optional and present
3. @file is optional and absent
Ignorant question: behavior in each case?
> #
> # @size: Size of the virtual disk in bytes
> #
> @@ -4968,7 +4969,7 @@
> ##
> { 'struct': 'BlockdevCreateOptionsLUKS',
> 'base': 'QCryptoBlockCreateOptionsLUKS',
> - 'data': { 'file': 'BlockdevRef',
> + 'data': { '*file': 'BlockdevRef',
> 'size': 'size',
> '*preallocation': 'PreallocMode' } }
