Re: [PATCH v4 2/3] target/riscv: Expose sdtrig ISA extension

2024-03-13 Thread Himanshu Chauhan
> On 13-Mar-2024, at 6:19 PM, Andrew Jones wrote: > > On Wed, Mar 13, 2024 at 05:48:16PM +0530, Himanshu Chauhan wrote: > ... >> #ifndef CONFIG_USER_ONLY >> +if (cpu->cfg.debug && cpu->cfg.ext_sdtrig) { >> + warn_report("Disabling debug property since sdtrig ISA > e

Re: [PATCH v4 2/3] target/riscv: Expose sdtrig ISA extension

2024-03-13 Thread Andrew Jones
On Wed, Mar 13, 2024 at 05:48:16PM +0530, Himanshu Chauhan wrote: ... > #ifndef CONFIG_USER_ONLY > +if (cpu->cfg.debug && cpu->cfg.ext_sdtrig) { > + warn_report("Disabling debug property since sdtrig ISA > >>> extension " > + "is enabled"); >

Re: [PATCH v4 2/3] target/riscv: Expose sdtrig ISA extension

2024-03-13 Thread Himanshu Chauhan
> On 13-Mar-2024, at 4:28 PM, Andrew Jones wrote: > > On Wed, Mar 13, 2024 at 03:50:16PM +0530, Himanshu Chauhan wrote: >> On Wed, Mar 13, 2024 at 3:24 PM Andrew Jones >> wrote: >> >>> On Wed, Mar 13, 2024 at 11:39:30AM +0530, Himanshu Chauhan wrote: This patch adds "sdtrig" in the ISA

Re: [PATCH v4 2/3] target/riscv: Expose sdtrig ISA extension

2024-03-13 Thread Andrew Jones
On Wed, Mar 13, 2024 at 03:50:16PM +0530, Himanshu Chauhan wrote: > On Wed, Mar 13, 2024 at 3:24 PM Andrew Jones > wrote: > > > On Wed, Mar 13, 2024 at 11:39:30AM +0530, Himanshu Chauhan wrote: > > > This patch adds "sdtrig" in the ISA string when sdtrig extension is > > enabled. > > > The sdtrig

Re: [PATCH v4 2/3] target/riscv: Expose sdtrig ISA extension

2024-03-13 Thread Himanshu Chauhan
On Wed, Mar 13, 2024 at 3:24 PM Andrew Jones wrote: > On Wed, Mar 13, 2024 at 11:39:30AM +0530, Himanshu Chauhan wrote: > > This patch adds "sdtrig" in the ISA string when sdtrig extension is > enabled. > > The sdtrig extension may or may not be implemented in a system. > Therefore, the > >

Re: [PATCH v4 2/3] target/riscv: Expose sdtrig ISA extension

2024-03-13 Thread Andrew Jones
On Wed, Mar 13, 2024 at 11:39:30AM +0530, Himanshu Chauhan wrote: > This patch adds "sdtrig" in the ISA string when sdtrig extension is enabled. > The sdtrig extension may or may not be implemented in a system. Therefore, the >-cpu rv64,sdtrig= > option can be used to dynamically turn s

[PATCH v4 2/3] target/riscv: Expose sdtrig ISA extension

2024-03-12 Thread Himanshu Chauhan
This patch adds "sdtrig" in the ISA string when sdtrig extension is enabled. The sdtrig extension may or may not be implemented in a system. Therefore, the -cpu rv64,sdtrig= option can be used to dynamically turn sdtrig extension on or off. Since, the sdtrig ISA extension is a superset