Re: [PATCH v4 15/53] semihosting: Remove GDB_O_BINARY

2022-06-09 Thread Richard Henderson
On 6/9/22 08:49, Alex Bennée wrote: Richard Henderson writes: The value is zero, and gdb always opens files in binary mode. Signed-off-by: Richard Henderson It might be worth mentioning these are the FILEIO_ flags in include/gdb/fileio.h to make future referencing easier. Comment added

Re: [PATCH v4 15/53] semihosting: Remove GDB_O_BINARY

2022-06-09 Thread Alex Bennée
Richard Henderson writes: > The value is zero, and gdb always opens files in binary mode. > > Signed-off-by: Richard Henderson It might be worth mentioning these are the FILEIO_ flags in include/gdb/fileio.h to make future referencing easier. Anyway: Reviewed-by: Alex Bennée > --- > sem

[PATCH v4 15/53] semihosting: Remove GDB_O_BINARY

2022-06-07 Thread Richard Henderson
The value is zero, and gdb always opens files in binary mode. Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index cebbad2355..92c13