Richard Henderson <richard.hender...@linaro.org> writes:
> The value is zero, and gdb always opens files in binary mode.
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
It might be worth mentioning these are the FILEIO_ flags in
include/gdb/fileio.h to make future referencing easier.
Anyway:
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
> ---
> semihosting/arm-compat-semi.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
> index cebbad2355..92c1375b15 100644
> --- a/semihosting/arm-compat-semi.c
> +++ b/semihosting/arm-compat-semi.c
> @@ -92,21 +92,20 @@
> #define GDB_O_APPEND 0x008
> #define GDB_O_CREAT 0x200
> #define GDB_O_TRUNC 0x400
> -#define GDB_O_BINARY 0
>
> static int gdb_open_modeflags[12] = {
> GDB_O_RDONLY,
> - GDB_O_RDONLY | GDB_O_BINARY,
> + GDB_O_RDONLY,
> + GDB_O_RDWR,
> GDB_O_RDWR,
> - GDB_O_RDWR | GDB_O_BINARY,
> GDB_O_WRONLY | GDB_O_CREAT | GDB_O_TRUNC,
> - GDB_O_WRONLY | GDB_O_CREAT | GDB_O_TRUNC | GDB_O_BINARY,
> + GDB_O_WRONLY | GDB_O_CREAT | GDB_O_TRUNC,
> + GDB_O_RDWR | GDB_O_CREAT | GDB_O_TRUNC,
> GDB_O_RDWR | GDB_O_CREAT | GDB_O_TRUNC,
> - GDB_O_RDWR | GDB_O_CREAT | GDB_O_TRUNC | GDB_O_BINARY,
> GDB_O_WRONLY | GDB_O_CREAT | GDB_O_APPEND,
> - GDB_O_WRONLY | GDB_O_CREAT | GDB_O_APPEND | GDB_O_BINARY,
> + GDB_O_WRONLY | GDB_O_CREAT | GDB_O_APPEND,
> + GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND,
> GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND,
> - GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND | GDB_O_BINARY
> };
>
> static int open_modeflags[12] = {
--
Alex Bennée
