Re: [PATCH v4 03/31] net/net: fix local variable shadowing in net_client_init

2019-10-08 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Don't shadow Error *err: it's a bad thing. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake Looks like a cleanup, not a bug fix. If that's the case, the commit message should say so: net/net: Clean up variable shadowing in n

[PATCH v4 03/31] net/net: fix local variable shadowing in net_client_init

2019-10-01 Thread Vladimir Sementsov-Ogievskiy
Don't shadow Error *err: it's a bad thing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- net/net.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/net/net.c b/net/net.c index 84aa6d8d00..9e93c3f8a1 100644 --- a/net/net.c +++ b/net