Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> writes: > Don't shadow Error *err: it's a bad thing. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > Reviewed-by: Eric Blake <ebl...@redhat.com>
Looks like a cleanup, not a bug fix. If that's the case, the commit message should say so: net/net: Clean up variable shadowing in net_client_init() Variable int err in inner scope shadows Error *err in outer scope. Patch looks good to me.