Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2021-02-02 Thread Paolo Bonzini
On 25/11/20 14:50, P J P wrote: +-- On Tue, 15 Sep 2020, P J P wrote --+ | +-- On Tue, 11 Aug 2020, P J P wrote --+ | | * This series asserts that MemoryRegionOps objects define read/write | | callback methods. Thus avoids potential NULL pointer dereference. | | ex. -> https://git.qemu.org/?

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-11-25 Thread P J P
+-- On Tue, 15 Sep 2020, P J P wrote --+ | +-- On Tue, 11 Aug 2020, P J P wrote --+ | | * This series asserts that MemoryRegionOps objects define read/write | | callback methods. Thus avoids potential NULL pointer dereference. | | ex. -> https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef346

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-09-15 Thread P J P
+-- On Tue, 11 Aug 2020, P J P wrote --+ | * This series asserts that MemoryRegionOps objects define read/write | callback methods. Thus avoids potential NULL pointer dereference. | ex. -> https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f5276292cadd326c21b2 | | * Also adds var

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-09-03 Thread P J P
+-- On Thu, 27 Aug 2020, P J P wrote --+ | +-- On Mon, 17 Aug 2020, P J P wrote --+ | | +-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+ | | | On 8/17/20 7:02 AM, P J P wrote: | | | > +-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+ | | | > | What about read_with_attrs()/write_wit

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-27 Thread P J P
+-- On Mon, 17 Aug 2020, P J P wrote --+ | +-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+ | | On 8/17/20 7:02 AM, P J P wrote: | | > +-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+ | | > | What about read_with_attrs()/write_with_attrs()? It seems they are part | | > | of the s

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-17 Thread P J P
+-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+ | On 8/17/20 7:02 AM, P J P wrote: | > +-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+ | > | What about read_with_attrs()/write_with_attrs()? It seems they are part | > | of the same problem. | > | > * read/write_with_attrs funct

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-16 Thread Philippe Mathieu-Daudé
On 8/17/20 7:02 AM, P J P wrote: > +-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+ > | On 8/11/20 1:41 PM, P J P wrote: > | > From: Prasad J Pandit > | > * This series asserts that MemoryRegionOps objects define read/write > | > callback methods. Thus avoids potential NULL pointer dere

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-16 Thread P J P
+-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+ | On 8/11/20 1:41 PM, P J P wrote: | > From: Prasad J Pandit | > * This series asserts that MemoryRegionOps objects define read/write | > callback methods. Thus avoids potential NULL pointer dereference. | > ex. -> https://git.qemu.org

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-16 Thread Philippe Mathieu-Daudé
On 8/11/20 1:41 PM, P J P wrote: > From: Prasad J Pandit > > Hello, > > * This series asserts that MemoryRegionOps objects define read/write > callback methods. Thus avoids potential NULL pointer dereference. > ex. -> > https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f527629

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-13 Thread Philippe Mathieu-Daudé
On 8/13/20 3:43 PM, P J P wrote: > +-- On Thu, 13 Aug 2020, David Gibson wrote --+ > | The overall idea seems fine. Looks like we could avoid a fair bit of > | boilerplate - and slightly reduce our binary size - by introducing a global > | unimplemented_write() function. IIRC in v2 or v3 it was

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-13 Thread P J P
+-- On Thu, 13 Aug 2020, David Gibson wrote --+ | The overall idea seems fine. Looks like we could avoid a fair bit of | boilerplate - and slightly reduce our binary size - by introducing a global | unimplemented_write() function. * You mean for after this assert(3) in memory_region_init_io cha

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-13 Thread David Gibson
On Tue, Aug 11, 2020 at 05:11:24PM +0530, P J P wrote: > From: Prasad J Pandit > > Hello, > > * This series asserts that MemoryRegionOps objects define read/write > callback methods. Thus avoids potential NULL pointer dereference. > ex. -> > https://git.qemu.org/?p=qemu.git;a=commit;h=bb150

[PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-11 Thread P J P
From: Prasad J Pandit Hello, * This series asserts that MemoryRegionOps objects define read/write callback methods. Thus avoids potential NULL pointer dereference. ex. -> https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f5276292cadd326c21b2 * Also adds various undefined Memo