On 8/13/20 3:43 PM, P J P wrote:
> +-- On Thu, 13 Aug 2020, David Gibson wrote --+
> | The overall idea seems fine.  Looks like we could avoid a fair bit of 
> | boilerplate - and slightly reduce our binary size - by introducing a global 
> | unimplemented_write() function.

IIRC in v2 or v3 it was mentioned each device has to be handled
differently, as it behaves differently, it sits on a particular bus, and
so on. So the preferred way is to have a device-specific handler.

(This explains v4 and why these patches took so long).

> 
> * You mean for after this assert(3) in memory_region_init_io change is 
> merged?  
>   This series attempts to define all missing r/w calls.
> 
> * There are also unassigned_mem_read/write functions, maybe those can be 
>   reused?
> 
> 
> Thank you.
> --
> Prasad J Pandit / Red Hat Product Security Team
> 8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
> 


Reply via email to