Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On Sun, Aug 16, 2020 at 11:26 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/16/20 5:57 PM, Rohit Shinde wrote: > > I misread the comment. The comment /* fallthrough */ was meant to stop > the > > compiler warning from occurring. I am trying to complete the bite sized > task >

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On 8/16/20 5:57 PM, Rohit Shinde wrote: > I misread the comment. The comment /* fallthrough */ was meant to stop the > compiler warning from occurring. I am trying to complete the bite sized task > mentioned here  under > "Compiler driven cleanups".

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On Sun, Aug 16, 2020 at 6:52 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/16/20 9:55 AM, Rohit Shinde wrote: > > Hey Richard, > > > > 1. So I should fork off the master again? > > Yes. > > There need to be special circumstances for not posting a patch set > relative to > mas

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On 8/16/20 9:55 AM, Rohit Shinde wrote: > Hey Richard, > > 1. So I should fork off the master again? Yes. There need to be special circumstances for not posting a patch set relative to master, and even then your cover letter would need to detail against what base the patch set applies. > 2. I

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

Hey Richard, 1. So I should fork off the master again? I am a bit unclear on the workflow, since this is my first doing patches via format-patch and send-email so I am making mistakes. 2. I just checked and my version of the code doesn't contain that line, so I am unsure on how tha

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On 8/15/20 7:31 PM, Rohit Shinde wrote: > /* range has been completed, fall through in order to pop option */ > -__attribute__((fallthrough)); > +/* fallthrough */ (1) Any patch should not be relative to your own v3. (2) The previous line already contains the words "fall t

[PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

Added fallthrough comment on line 270 to fix compiler warning Signed-off-by: Rohit Shinde --- qapi/opts-visitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 43cf60d3a0..3422ff265e 100644 --- a/qapi/opts-visitor.c +++ b/qapi