On Sun, Aug 16, 2020 at 6:52 PM Richard Henderson < richard.hender...@linaro.org> wrote:
> On 8/16/20 9:55 AM, Rohit Shinde wrote: > > Hey Richard, > > > > 1. So I should fork off the master again? > > Yes. > > There need to be special circumstances for not posting a patch set > relative to > master, and even then your cover letter would need to detail against what > base > the patch set applies. > > > 2. I just checked and my version of the code doesn't contain that line, > so I > > am unsure on how that line got there. I was trying to fix the > compiler > > warnings. Could you please guide me on how I create the next version > of a > > patch? > > That makes no sense at all. The line was added at the same time as the > code > above it, in d8754f40acb. > I misread the comment. The comment /* fallthrough */ was meant to stop the compiler warning from occurring. I am trying to complete the bite sized task mentioned here <https://wiki.qemu.org/Contribute/BiteSizedTasks> under "Compiler driven cleanups". I wanted to take that up to get more familiar with the codebase. > > There should be nothing to fix. > > > r~ >
