Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-15 Thread Maxim Levitsky
On Thu, 2019-11-14 at 07:33 -0600, Eric Blake wrote: > On 11/14/19 4:04 AM, Maxim Levitsky wrote: > > On Wed, 2019-11-13 at 20:46 -0600, Eric Blake wrote: > > > As long as we limit NBD names to 256 bytes (the bare minimum permitted > > > by the standard), stack-allocation works for parsing a name r

Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-15 Thread Vladimir Sementsov-Ogievskiy
14.11.2019 5:46, Eric Blake wrote: > As long as we limit NBD names to 256 bytes (the bare minimum permitted > by the standard), stack-allocation works for parsing a name received > from the client. But as mentioned in a comment, we eventually want to > permit up to the 4k maximum of the NBD standa

Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-14 Thread Eric Blake
On 11/14/19 4:04 AM, Maxim Levitsky wrote: On Wed, 2019-11-13 at 20:46 -0600, Eric Blake wrote: As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventual

Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-14 Thread Maxim Levitsky
On Wed, 2019-11-13 at 20:46 -0600, Eric Blake wrote: > As long as we limit NBD names to 256 bytes (the bare minimum permitted > by the standard), stack-allocation works for parsing a name received > from the client. But as mentioned in a comment, we eventually want to > permit up to the 4k maximum

Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-13 Thread Eric Blake
On 11/13/19 8:46 PM, Eric Blake wrote: As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventually want to permit up to the 4k maximum of the NBD standard

[PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-13 Thread Eric Blake
As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventually want to permit up to the 4k maximum of the NBD standard, which is too large for stack allocation