14.11.2019 5:46, Eric Blake wrote: > As long as we limit NBD names to 256 bytes (the bare minimum permitted > by the standard), stack-allocation works for parsing a name received > from the client. But as mentioned in a comment, we eventually want to > permit up to the 4k maximum of the NBD standard, which is too large > for stack allocation; so switch everything in the server to use heap > allocation. For now, there is no change in actually supported name > length. > > Signed-off-by: Eric Blake <ebl...@redhat.com>
with mentioned fix: Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> PS: Great, how using g_autofree simplifies reviewing! I don't need to check that something is leaked at some return point. -- Best regards, Vladimir