Re: [PATCH v3 08/20] target/arm: Remove CPSR_RESERVED

2020-02-08 Thread Richard Henderson
On 2/7/20 5:36 PM, Peter Maydell wrote: >> -return cpsr_read(env) & ~(CPSR_EXEC | CPSR_RESERVED); >> +/* >> + * We store the ARMv8 PSTATE.SS bit in env->uncached_cpsr. >> + * This is convenient for populating SPSR_ELx, but must be >> + * hidden from aarch32 mode, where it is not

Re: [PATCH v3 08/20] target/arm: Remove CPSR_RESERVED

2020-02-07 Thread Peter Maydell
On Mon, 3 Feb 2020 at 14:47, Richard Henderson wrote: > > The only remaining use was in op_helper.c. Use PSTATE_SS > directly, and move the commentary so that it is more obvious > what is going on. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 6 -- > target/arm/op_h

[PATCH v3 08/20] target/arm: Remove CPSR_RESERVED

2020-02-03 Thread Richard Henderson
The only remaining use was in op_helper.c. Use PSTATE_SS directly, and move the commentary so that it is more obvious what is going on. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 6 -- target/arm/op_helper.c | 9 - 2 files changed, 8 insertions(+), 7 deletions(-)