Re: [PATCH v3 02/18] ui: Fix silent truncation of numeric keys in HMP sendkey

2023-01-09 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Keys are int. HMP sendkey assigns them from the value strtoul(), >> silently truncating values greater than INT_MAX. Fix to reject them. >> >> While there, use qemu_strtoul() instead of strtoul() so checkpatch

Re: [PATCH v3 02/18] ui: Fix silent truncation of numeric keys in HMP sendkey

2023-01-04 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Keys are int. HMP sendkey assigns them from the value strtoul(), > silently truncating values greater than INT_MAX. Fix to reject them. > > While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl > won't complain. Last time through

[PATCH v3 02/18] ui: Fix silent truncation of numeric keys in HMP sendkey

2022-12-20 Thread Markus Armbruster
Keys are int. HMP sendkey assigns them from the value strtoul(), silently truncating values greater than INT_MAX. Fix to reject them. While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl won't complain. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- mon