"Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Keys are int. HMP sendkey assigns them from the value strtoul(), >> silently truncating values greater than INT_MAX. Fix to reject them. >> >> While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl >> won't complain. > > Last time through you said you could switch to qemu_strtoui, but
Did I? Oh, I did in review of [PATCH 08/12] pci: Fix silent truncation of pcie_aer_inject_error argument but failed to do it here, too. > I just noticed we've actually got a qemu_strto*i* - that > would remove the value comparison Thanks!