Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-12-08 Thread Yong Huang
On Wed, Dec 4, 2024 at 1:40 AM Peter Xu wrote: > On Tue, Dec 03, 2024 at 10:15:57AM -0300, Fabiano Rosas wrote: > > We shouldn't be adding warnings to the build like that. When building > > static binaries, I'd assume the person at least knows there's a -static > > in there somewhere. If you're j

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-12-03 Thread Peter Xu
On Tue, Dec 03, 2024 at 10:15:57AM -0300, Fabiano Rosas wrote: > We shouldn't be adding warnings to the build like that. When building > static binaries, I'd assume the person at least knows there's a -static > in there somewhere. If you're just building the system binaries and > warnings start to

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-12-03 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Tue, Dec 03, 2024 at 09:20:44AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Dec 02, 2024 at 02:49:33PM -0500, Peter Xu wrote: >> >> On Sat, Nov 30, 2024 at 10:01:43PM +0800, Yong Huang wrote: >> >> > On Fri, Nov 29, 2024 at 9:44 PM F

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-12-03 Thread Daniel P . Berrangé
On Tue, Dec 03, 2024 at 09:20:44AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Mon, Dec 02, 2024 at 02:49:33PM -0500, Peter Xu wrote: > >> On Sat, Nov 30, 2024 at 10:01:43PM +0800, Yong Huang wrote: > >> > On Fri, Nov 29, 2024 at 9:44 PM Fabiano Rosas wrote: > >> For the st

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-12-03 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Mon, Dec 02, 2024 at 02:49:33PM -0500, Peter Xu wrote: >> On Sat, Nov 30, 2024 at 10:01:43PM +0800, Yong Huang wrote: >> > On Fri, Nov 29, 2024 at 9:44 PM Fabiano Rosas wrote: >> For the stress.c warnings/error, I saw another one warning with gcc when >> built it

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-12-03 Thread Daniel P . Berrangé
On Mon, Dec 02, 2024 at 02:49:33PM -0500, Peter Xu wrote: > On Sat, Nov 30, 2024 at 10:01:43PM +0800, Yong Huang wrote: > > On Fri, Nov 29, 2024 at 9:44 PM Fabiano Rosas wrote: > For the stress.c warnings/error, I saw another one warning with gcc when > built it locally, then I found Fabiano's CI

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-12-02 Thread Peter Xu
On Sat, Nov 30, 2024 at 10:01:43PM +0800, Yong Huang wrote: > On Fri, Nov 29, 2024 at 9:44 PM Fabiano Rosas wrote: > > > Fabiano Rosas writes: > > > > > Yong Huang writes: > > > > > >> On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: > > >> > > >>> yong.hu...@smartx.com writes: > > >>> >

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-11-30 Thread Yong Huang
On Fri, Nov 29, 2024 at 9:44 PM Fabiano Rosas wrote: > Fabiano Rosas writes: > > > Yong Huang writes: > > > >> On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: > >> > >>> yong.hu...@smartx.com writes: > >>> > >>> > From: Hyman Huang > >>> > > >>> > v3: > >>> > 1. Remove the two redundant

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-11-29 Thread Fabiano Rosas
Fabiano Rosas writes: > Yong Huang writes: > >> On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: >> >>> yong.hu...@smartx.com writes: >>> >>> > From: Hyman Huang >>> > >>> > v3: >>> > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by >>> Daniel >>> > >>> > Please revi

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-11-29 Thread Fabiano Rosas
Yong Huang writes: > On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: > >> yong.hu...@smartx.com writes: >> >> > From: Hyman Huang >> > >> > v3: >> > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by >> Daniel >> > >> > Please review, thanks >> > Yong >> > >> > v2: >>

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-11-29 Thread Yong Huang
On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: > yong.hu...@smartx.com writes: > > > From: Hyman Huang > > > > v3: > > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by > Daniel > > > > Please review, thanks > > Yong > > > > v2: > > 1. Update the MAINTAINERS section s

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-10-24 Thread Peter Xu
On Thu, Oct 24, 2024 at 10:06:51AM +0800, Yong Huang wrote: > Indeed, we could document how to build and use the guestperf, > refining it to be more convenient to use. If to do so, please feel free to add a "test" entry in devel/migration too no matter to put the doc there, or just add a reference

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-10-23 Thread Yong Huang
On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: > yong.hu...@smartx.com writes: > > > From: Hyman Huang > > > > v3: > > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by > Daniel > > > > Please review, thanks > > Yong > > > > v2: > > 1. Update the MAINTAINERS section s

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-10-23 Thread Fabiano Rosas
yong.hu...@smartx.com writes: > From: Hyman Huang > > v3: > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by Daniel > > Please review, thanks > Yong > > v2: > 1. Update the MAINTAINERS section suggested by Fabiano Rosas > 2. Ensure the dependencies when build the initrd-st

[PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-10-21 Thread yong . huang
From: Hyman Huang v3: 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by Daniel Please review, thanks Yong v2: 1. Update the MAINTAINERS section suggested by Fabiano Rosas 2. Ensure the dependencies when build the initrd-stress.img suggested by Daniel 3. Fix some bugs v1: