Fabiano Rosas <faro...@suse.de> writes: > Yong Huang <yong.hu...@smartx.com> writes: > >> On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas <faro...@suse.de> wrote: >> >>> yong.hu...@smartx.com writes: >>> >>> > From: Hyman Huang <yong.hu...@smartx.com> >>> > >>> > v3: >>> > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by >>> Daniel >>> > >>> > Please review, thanks >>> > Yong >>> > >>> > v2: >>> > 1. Update the MAINTAINERS section suggested by Fabiano Rosas >>> > 2. Ensure the dependencies when build the initrd-stress.img suggested by >>> Daniel >>> > 3. Fix some bugs >>> > >>> > v1: >>> > The previous patchset: >>> > >>> https://lore.kernel.org/qemu-devel/cover.1722957352.git.yong.hu...@smartx.com/ >>> > does not made the necessary changes and tests for the upstream version. >>> > >>> > This patchset works for that: >>> > 1. Move the guestperf to scripts directory suggested by Fabiano Rosas >>> > 2. Make initrd-stress.img built by default suggested by Fabiano Rosas >>> > 3. Make the necessary changes to adapt the latest multifd behavior >>> > 4. A nitpick for multifd migration >>> > 5. Support multifd compression option >>> > >>> > Hyman Huang (5): >>> > tests/migration: Move the guestperf tool to scripts directory >>> > tests/migration: Make initrd-stress.img built by default >>> > guestperf: Support deferred migration for multifd >>> > guestperf: Nitpick the inconsistent parameters >>> > guestperf: Introduce multifd compression option >>> > >>> > MAINTAINERS | 5 +++ >>> > .../migration/guestperf-batch.py | 0 >>> > .../migration/guestperf-plot.py | 0 >>> > {tests => scripts}/migration/guestperf.py | 0 >>> > .../migration/guestperf/__init__.py | 0 >>> > .../migration/guestperf/comparison.py | 15 ++++++++- >>> > .../migration/guestperf/engine.py | 33 ++++++++++++++++--- >>> > .../migration/guestperf/hardware.py | 0 >>> > .../migration/guestperf/plot.py | 0 >>> > .../migration/guestperf/progress.py | 0 >>> > .../migration/guestperf/report.py | 0 >>> > .../migration/guestperf/scenario.py | 7 ++-- >>> > .../migration/guestperf/shell.py | 3 ++ >>> > .../migration/guestperf/timings.py | 0 >>> > tests/migration/meson.build | 30 +++++++++-------- >>> > 15 files changed, 73 insertions(+), 20 deletions(-) >>> > rename {tests => scripts}/migration/guestperf-batch.py (100%) >>> > rename {tests => scripts}/migration/guestperf-plot.py (100%) >>> > rename {tests => scripts}/migration/guestperf.py (100%) >>> > rename {tests => scripts}/migration/guestperf/__init__.py (100%) >>> > rename {tests => scripts}/migration/guestperf/comparison.py (89%) >>> > rename {tests => scripts}/migration/guestperf/engine.py (93%) >>> > rename {tests => scripts}/migration/guestperf/hardware.py (100%) >>> > rename {tests => scripts}/migration/guestperf/plot.py (100%) >>> > rename {tests => scripts}/migration/guestperf/progress.py (100%) >>> > rename {tests => scripts}/migration/guestperf/report.py (100%) >>> > rename {tests => scripts}/migration/guestperf/scenario.py (93%) >>> > rename {tests => scripts}/migration/guestperf/shell.py (98%) >>> > rename {tests => scripts}/migration/guestperf/timings.py (100%) >>> >>> Reviewed-by: Fabiano Rosas <faro...@suse.de> >>> >>> >>> Thinking out loud a little bit, it's still somewhat obscure from which >>> directory this script should be called. None of these invocations work: >>> >>> $ ./scripts/migration/guestperf.py >>> >>> $ ./build/scripts/migration/guestperf.py >>> >>> $ cd scripts/migration >>> $ ./guestperf.py >>> >>> $ cd build/scripts/migration >>> $ ./guestperf.py >>> >>> Failed to open file “tests/migration/initrd-stress.img”: open() failed: >>> No such file or directory >>> >>> This is the only one that works: >>> $ cd build >>> $ ./scripts/migration/guestperf.py >>> >>> Maybe we could improve that somehow in the future. >>> >>> >> This patchset could be queued now, >> Or after refining the documents mentioned above later? > > I think it's ok. Let me just rebase this on top of the other series that > touches the tests/migration/ directory. I'll repost soon.
Well, not so fast, the CI doesn't like the addition of stress.c: https://gitlab.com/farosas/qemu/-/jobs/8504697373 clang: error: argument unused during compilation: '-pie' https://gitlab.com/farosas/qemu/-/jobs/8504697378 undefined reference to `_DYNAMIC'
