Re: [PATCH v2 7/9] vfio/igd: Decouple common quirks from legacy mode

2025-03-04 Thread Corvin Köhne
On Tue, 2025-03-04 at 09:07 +0100, Corvin Köhne wrote: > On Tue, 2025-03-04 at 01:52 +0800, Tomita Moeko wrote: > > So far, IGD-specific quirks all require enabling legacy mode, which is > > toggled by assigning IGD to 00:02.0. However, some quirks, like the BDSM > > and GGC register quirks, should

Re: [PATCH v2 7/9] vfio/igd: Decouple common quirks from legacy mode

2025-03-04 Thread Corvin Köhne
On Tue, 2025-03-04 at 01:52 +0800, Tomita Moeko wrote: > So far, IGD-specific quirks all require enabling legacy mode, which is > toggled by assigning IGD to 00:02.0. However, some quirks, like the BDSM > and GGC register quirks, should be applied to all supported IGD devices. > A new feature bit,

Re: [PATCH v2 7/9] vfio/igd: Decouple common quirks from legacy mode

2025-03-03 Thread Alex Williamson
On Tue, 4 Mar 2025 01:52:17 +0800 Tomita Moeko wrote: > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index a58d555934..b0620a0ae8 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3363,6 +3363,8 @@ static const Property vfio_pci_dev_properties[] = { > VFIO_FEATURE_ENA

[PATCH v2 7/9] vfio/igd: Decouple common quirks from legacy mode

2025-03-03 Thread Tomita Moeko
So far, IGD-specific quirks all require enabling legacy mode, which is toggled by assigning IGD to 00:02.0. However, some quirks, like the BDSM and GGC register quirks, should be applied to all supported IGD devices. A new feature bit, VFIO_FEATURE_ENABLE_IGD_LEGACY_MODE, is introduced to control t