On Tue, 4 Mar 2025 01:52:17 +0800
Tomita Moeko <tomitamo...@gmail.com> wrote:
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index a58d555934..b0620a0ae8 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3363,6 +3363,8 @@ static const Property vfio_pci_dev_properties[] = {
> VFIO_FEATURE_ENABLE_REQ_BIT, true),
> DEFINE_PROP_BIT("x-igd-opregion", VFIOPCIDevice, features,
> VFIO_FEATURE_ENABLE_IGD_OPREGION_BIT, false),
> + DEFINE_PROP_BIT("x-igd-legacy-mode", VFIOPCIDevice, features,
> + VFIO_FEATURE_ENABLE_IGD_LEGACY_MODE_BIT, true),
Shouldn't this be an on/off/auto property with default set to auto?
That way we can have a soft fail when set to "auto" and requirements
don't align, and a hard fail when set to "on". Thanks,
Alex
