Re: [PATCH v2 25/26] tests: replace qemu_set_nonblock()

2022-05-03 Thread Daniel P . Berrangé
On Tue, Apr 26, 2022 at 01:27:14PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The call is POSIX-specific. Use the dedicated GLib API. > > Signed-off-by: Marc-André Lureau > --- > tests/qtest/vhost-user-test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(

Re: [PATCH v2 25/26] tests: replace qemu_set_nonblock()

2022-04-27 Thread Thomas Huth
On 27/04/2022 12.33, Marc-André Lureau wrote: Hi On Wed, Apr 27, 2022 at 1:41 PM Thomas Huth wrote: On 26/04/2022 11.27, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The call is POSIX-specific. Use the dedicated GLib API. g_unix_set_fd_nonblocking() is also available on Uni

Re: [PATCH v2 25/26] tests: replace qemu_set_nonblock()

2022-04-27 Thread Marc-André Lureau
Hi On Wed, Apr 27, 2022 at 1:41 PM Thomas Huth wrote: > > On 26/04/2022 11.27, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The call is POSIX-specific. Use the dedicated GLib API. > > g_unix_set_fd_nonblocking() is also available on Unix-like systems according > to its

Re: [PATCH v2 25/26] tests: replace qemu_set_nonblock()

2022-04-27 Thread Thomas Huth
On 26/04/2022 11.27, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The call is POSIX-specific. Use the dedicated GLib API. g_unix_set_fd_nonblocking() is also available on Unix-like systems according to its name, I suppose? So what's the advantage of this change? Thomas Si

[PATCH v2 25/26] tests: replace qemu_set_nonblock()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau The call is POSIX-specific. Use the dedicated GLib API. Signed-off-by: Marc-André Lureau --- tests/qtest/vhost-user-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index ee30f547