On 27/04/2022 12.33, Marc-André Lureau wrote:
Hi
On Wed, Apr 27, 2022 at 1:41 PM Thomas Huth <th...@redhat.com> wrote:
On 26/04/2022 11.27, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau <marcandre.lur...@redhat.com>
The call is POSIX-specific. Use the dedicated GLib API.
g_unix_set_fd_nonblocking() is also available on Unix-like systems according
to its name, I suppose? So what's the advantage of this change?
This is a preliminary patch before the last patch
(https://patchew.org/QEMU/20220426092715.3931705-1-marcandre.lur...@redhat.com/20220426092715.3931705-27-marcandre.lur...@redhat.com/)
We should reserve qemu_socket_set_*block() usage to socket-like fd.
Ok, makes sense now, thanks.
Reviewed-by: Thomas Huth <th...@redhat.com>
PS: In case you respin, it might make sense to add a sentence à la "We're
going to limit qemu_set_nonblock() to sockets only" to the commit description.
