Re: [PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-18 Thread Clément Léger
On 18/10/2024 04:21, Alistair Francis wrote: > On Fri, Oct 18, 2024 at 4:27 AM Ved Shanbhogue wrote: >> >> Alistair Francis wrote: >>> $ grep -r sstatus.SDT | grep SRET >>> src/hypervisor.adoc:if the new privilege mode is VU, the `SRET` >>> instruction sets `vsstatus.SDT` >>> >>> What am I miss

Re: [PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-17 Thread Alistair Francis
On Fri, Oct 18, 2024 at 4:27 AM Ved Shanbhogue wrote: > > Alistair Francis wrote: > >$ grep -r sstatus.SDT | grep SRET > >src/hypervisor.adoc:if the new privilege mode is VU, the `SRET` > >instruction sets `vsstatus.SDT` > > > >What am I missing here? > > https://github.com/riscv/riscv-isa-manual/

Re: [PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-17 Thread Ved Shanbhogue
Alistair Francis wrote: $ grep -r sstatus.SDT | grep SRET src/hypervisor.adoc:if the new privilege mode is VU, the `SRET` instruction sets `vsstatus.SDT` What am I missing here? https://github.com/riscv/riscv-isa-manual/blob/ef2ec9dc9afd003d0dab6d5ca36db59864c8483c/src/machine.adoc?plain=1#L53

Re: [PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-16 Thread Alistair Francis
On Sat, Oct 12, 2024 at 4:52 AM Ved Shanbhogue wrote: > > Alistair Francis wrote: > >> When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared > >> when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared > >> when returning to U, VS or VU and VSSTATUS.SDT is cleared whe

Re: [PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-11 Thread Ved Shanbhogue
Alistair Francis wrote: When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared when returning to U, VS or VU and VSSTATUS.SDT is cleared when returning to VU from HS. I don't see mret being mentioned in the spe

Re: [PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-10 Thread Alistair Francis
On Wed, Sep 25, 2024 at 9:58 PM Clément Léger wrote: > > When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared > when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared > when returning to U, VS or VU and VSSTATUS.SDT is cleared when returning > to VU from HS. I don'

[PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-09-25 Thread Clément Léger
When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared when returning to U, VS or VU and VSSTATUS.SDT is cleared when returning to VU from HS. Signed-off-by: Clément Léger --- target/riscv/op_helper.c | 35 +