Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-14 Thread Igor Mammedov
On Tue, 12 May 2020 17:59:25 +0200 Auger Eric wrote: > Hi Igor, > > On 5/12/20 4:14 PM, Igor Mammedov wrote: > > On Wed, 6 May 2020 05:58:25 -0400 > > "Michael S. Tsirkin" wrote: > > > >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: > >>> I realize this function is just ge

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-12 Thread Auger Eric
Hi Igor, On 5/12/20 4:14 PM, Igor Mammedov wrote: > On Wed, 6 May 2020 05:58:25 -0400 > "Michael S. Tsirkin" wrote: > >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: >>> I realize this function is just getting moved, but maybe it should get >>> converted to the build_append* API

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-12 Thread Auger Eric
Hi Igor, On 5/12/20 4:10 PM, Igor Mammedov wrote: > On Wed, 6 May 2020 11:50:09 +0200 > Auger Eric wrote: > >> Hi, >> >> On 5/6/20 8:33 AM, Andrew Jones wrote: >>> On Tue, May 05, 2020 at 04:44:17PM +0200, Eric Auger wrote: We plan to build the tpm2 table on ARM too. In order to reuse the

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-12 Thread Igor Mammedov
On Wed, 6 May 2020 05:58:25 -0400 "Michael S. Tsirkin" wrote: > On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: > > I realize this function is just getting moved, but maybe it should get > > converted to the build_append* API while being moved? > > I'd rather refactoring was done

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-12 Thread Igor Mammedov
On Wed, 6 May 2020 11:50:09 +0200 Auger Eric wrote: > Hi, > > On 5/6/20 8:33 AM, Andrew Jones wrote: > > On Tue, May 05, 2020 at 04:44:17PM +0200, Eric Auger wrote: > >> We plan to build the tpm2 table on ARM too. In order to reuse the > >> generation code, let's move build_tpm2() to aml-build

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-06 Thread Michael S. Tsirkin
On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: > I realize this function is just getting moved, but maybe it should get > converted to the build_append* API while being moved? I'd rather refactoring was done in a separate patch - easier to review. -- MST

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-06 Thread Auger Eric
Hi, On 5/6/20 8:33 AM, Andrew Jones wrote: > On Tue, May 05, 2020 at 04:44:17PM +0200, Eric Auger wrote: >> We plan to build the tpm2 table on ARM too. In order to reuse the >> generation code, let's move build_tpm2() to aml-build.c. >> >> No change in the implementation. >> >> Signed-off-by: Eric

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-05 Thread Andrew Jones
On Tue, May 05, 2020 at 04:44:17PM +0200, Eric Auger wrote: > We plan to build the tpm2 table on ARM too. In order to reuse the > generation code, let's move build_tpm2() to aml-build.c. > > No change in the implementation. > > Signed-off-by: Eric Auger > --- > include/hw/acpi/aml-build.h | 2

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-05 Thread Stefan Berger
On 5/5/20 10:44 AM, Eric Auger wrote: We plan to build the tpm2 table on ARM too. In order to reuse the generation code, let's move build_tpm2() to aml-build.c. No change in the implementation. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- include/hw/acpi/aml-build.h | 2 ++

[PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-05 Thread Eric Auger
We plan to build the tpm2 table on ARM too. In order to reuse the generation code, let's move build_tpm2() to aml-build.c. No change in the implementation. Signed-off-by: Eric Auger --- include/hw/acpi/aml-build.h | 2 ++ hw/acpi/aml-build.c | 30 ++ hw/i386