Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Klaus Jensen
On Nov 10 10:59, Philippe Mathieu-Daudé wrote: > On 10/11/22 07:23, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Make nvme_check_constraints() return a bool and fix an invalid error > > propagation where the actual error is thrown away in favor of an unused > > local Error value. > > > > S

Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Markus Armbruster
Klaus Jensen writes: > From: Klaus Jensen > > Make nvme_check_constraints() return a bool and fix an invalid error > propagation where the actual error is thrown away in favor of an unused > local Error value. Is it? I think you're talking about ... > Signed-off-by: Klaus Jensen > --- > hw/

Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Philippe Mathieu-Daudé
On 10/11/22 07:23, Klaus Jensen wrote: From: Klaus Jensen Make nvme_check_constraints() return a bool and fix an invalid error propagation where the actual error is thrown away in favor of an unused local Error value. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 48 +

[PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-09 Thread Klaus Jensen
From: Klaus Jensen Make nvme_check_constraints() return a bool and fix an invalid error propagation where the actual error is thrown away in favor of an unused local Error value. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 48 +++- 1 file change