Re: [PATCH v2 1/2] dump: simplify a bit kdump get_next_page()

2022-09-05 Thread Marc-André Lureau
Hi On Mon, Sep 5, 2022 at 5:28 PM Peter Maydell wrote: > On Mon, 5 Sept 2022 at 13:57, wrote: > > > > From: Marc-André Lureau > > > > This should be functionally equivalent, but slightly easier to read, > > with simplified paths and checks at the end of the function. > > > > The following patc

Re: [PATCH v2 1/2] dump: simplify a bit kdump get_next_page()

2022-09-05 Thread Peter Maydell
On Mon, 5 Sept 2022 at 13:57, wrote: > > From: Marc-André Lureau > > This should be functionally equivalent, but slightly easier to read, > with simplified paths and checks at the end of the function. > > The following patch is a major rewrite to get rid of the assert(). > > Signed-off-by: Marc-A

Re: [PATCH v2 1/2] dump: simplify a bit kdump get_next_page()

2022-09-05 Thread David Hildenbrand
On 05.09.22 14:57, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This should be functionally equivalent, but slightly easier to read, with simplified paths and checks at the end of the function. The following patch is a major rewrite to get rid of the assert(). Signed-off-by: Mar

[PATCH v2 1/2] dump: simplify a bit kdump get_next_page()

2022-09-05 Thread marcandre . lureau
From: Marc-André Lureau This should be functionally equivalent, but slightly easier to read, with simplified paths and checks at the end of the function. The following patch is a major rewrite to get rid of the assert(). Signed-off-by: Marc-André Lureau --- dump/dump.c | 21 --