Hi On Mon, Sep 5, 2022 at 5:28 PM Peter Maydell <peter.mayd...@linaro.org> wrote:
> On Mon, 5 Sept 2022 at 13:57, <marcandre.lur...@redhat.com> wrote: > > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > This should be functionally equivalent, but slightly easier to read, > > with simplified paths and checks at the end of the function. > > > > The following patch is a major rewrite to get rid of the assert(). > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > dump/dump.c | 21 ++++++++------------- > > roms/SLOF | 2 +- > > 2 files changed, 9 insertions(+), 14 deletions(-) > > > diff --git a/roms/SLOF b/roms/SLOF > > index 6b6c16b4b4..5b4c5acdcd 160000 > > --- a/roms/SLOF > > +++ b/roms/SLOF > > @@ -1 +1 @@ > > -Subproject commit 6b6c16b4b40763507cf1f518096f3c3883c5cf2d > > +Subproject commit 5b4c5acdcd552a4e1796aeca6bb700f6cbb0282d > > This shouldn't be in here, right? (I'm guessing a rebase > accident -- git submodules have terrible ergonomics.) > indeed, my bad will fix in v3 (or eventually in PR?) -- Marc-André Lureau
