Re: [PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread Marc-André Lureau
On Fri, Nov 27, 2020 at 11:15 AM Gerd Hoffmann wrote: > Hi, > > > > #if defined AUDIO_BREAKPOINT_ON_BUG > > > # if defined HOST_I386 > > > + __asm__ ("int3"); > > > # else > > > abort (); > > > # endif > > > -- > > > 2.29.0 > > > > I would prefer to just drop this attempt t

Re: [PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread Gerd Hoffmann
Hi, > > #if defined AUDIO_BREAKPOINT_ON_BUG > > # if defined HOST_I386 > > + __asm__ ("int3"); > > # else > > abort (); > > # endif > > -- > > 2.29.0 > > I would prefer to just drop this attempt to emit an inline > breakpoint insn (which won't work on non-x86 hosts and seem

Re: [PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread Marc-André Lureau
Hi On Thu, Nov 26, 2020 at 4:08 PM Peter Maydell wrote: > On Thu, 26 Nov 2020 at 11:30, wrote: > > > > From: Marc-André Lureau > > > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > > Drop MSVC fallback path. > > > > Signed-off-by: Marc-André Lureau > > --- > > audio/aud

Re: [PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > Drop MSVC fallback path. > > Signed-off-by: Marc-André Lureau > --- > audio/audio.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --

[PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires either GCC or Clang, which both advertize __GNUC__. Drop MSVC fallback path. Signed-off-by: Marc-André Lureau --- audio/audio.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 46578e4a58..d7a00