On Fri, Nov 27, 2020 at 11:15 AM Gerd Hoffmann <kra...@redhat.com> wrote:
> Hi,
>
> > > #if defined AUDIO_BREAKPOINT_ON_BUG
> > > # if defined HOST_I386
> > > + __asm__ ("int3");
> > > # else
> > > abort ();
> > > # endif
> > > --
> > > 2.29.0
> >
> > I would prefer to just drop this attempt to emit an inline
> > breakpoint insn (which won't work on non-x86 hosts and seems
> > to me to have no benefit over just calling abort(), which will
> > also drop you into the debugger) and simply make it abort() if
> > AUDIO_BREAKPOINT_ON_BUG is defined. Gerd, do you have an
> > opinion ?
>
> kraxel@sirius ~/projects/qemu# git grep AUDIO_BREAKPOINT_ON_BUG
> audio/audio.c:#if defined AUDIO_BREAKPOINT_ON_BUG
>
> Seems this is unused, so just remove it?
>
>
I think the original intention was to build with CFLAGS set manually for
debugging this limited case. (Iirc, we have other such #ifdef lurking
around)
--
Marc-André Lureau
