On Wed, Oct 23, 2024 at 12:48:33PM +0200, Paolo Bonzini wrote:
> Date: Wed, 23 Oct 2024 12:48:33 +0200
> From: Paolo Bonzini
> Subject: Re: [PATCH v2 05/13] rust: remove uses of #[no_mangle]
>
> On 10/21/24 18:35, Paolo Bonzini wrote:
> > @@ -566,7 +563,6 @
On Mon, Oct 21, 2024 at 06:35:30PM +0200, Paolo Bonzini wrote:
> Date: Mon, 21 Oct 2024 18:35:30 +0200
> From: Paolo Bonzini
> Subject: [PATCH v2 05/13] rust: remove uses of #[no_mangle]
> X-Mailer: git-send-email 2.46.2
>
> Mangled symbols do not cause any issue; disablin
On 10/21/24 18:35, Paolo Bonzini wrote:
@@ -566,7 +563,6 @@ pub fn update(&self) {
/// # Safety
///
/// We expect the FFI user of this function to pass a valid pointer for `chr`.
-#[no_mangle]
pub unsafe extern "C" fn pl011_create(
addr: u64,
irq: qemu_irq,
This _needs_ to be
Mangled symbols do not cause any issue; disabling mangling is only useful if
C headers reference the Rust function, which is not the case here.
Reviewed-by: Junjie Mao
Signed-off-by: Paolo Bonzini
---
rust/hw/char/pl011/src/device.rs | 5 -
rust/hw/char/pl011/src/device_class.rs | 2 -
