Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

On 11/17/22 15:04, Alex Bennée wrote: Cédric Le Goater writes: Hello Alex, On 11/11/22 15:55, Alex Bennée wrote: This attempts to deal with the problem of login prompts not being guaranteed to be terminated with a newline. The solution to this is to peek at the incoming data looking to see

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

Cédric Le Goater writes: > Hello Alex, > > On 11/11/22 15:55, Alex Bennée wrote: >> This attempts to deal with the problem of login prompts not being >> guaranteed to be terminated with a newline. The solution to this is to >> peek at the incoming data looking to see if we see an up-coming matc

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

On Thu, 17 Nov 2022 at 13:39, Cédric Le Goater wrote: > > Hello Alex, > > On 11/11/22 15:55, Alex Bennée wrote: > > This attempts to deal with the problem of login prompts not being > > guaranteed to be terminated with a newline. The solution to this is to > > peek at the incoming data looking to

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

Hello Alex, On 11/11/22 15:55, Alex Bennée wrote: This attempts to deal with the problem of login prompts not being guaranteed to be terminated with a newline. The solution to this is to peek at the incoming data looking to see if we see an up-coming match before we fall back to the old readline

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

On Fri, 11 Nov 2022 at 14:58, Alex Bennée wrote: > > This attempts to deal with the problem of login prompts not being > guaranteed to be terminated with a newline. The solution to this is to > peek at the incoming data looking to see if we see an up-coming match > before we fall back to the old r

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

On 14/11/22 17:28, Peter Maydell wrote: On Fri, 11 Nov 2022 at 14:58, Alex Bennée wrote: This attempts to deal with the problem of login prompts not being guaranteed to be terminated with a newline. The solution to this is to peek at the incoming data looking to see if we see an up-coming matc

[PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

This attempts to deal with the problem of login prompts not being guaranteed to be terminated with a newline. The solution to this is to peek at the incoming data looking to see if we see an up-coming match before we fall back to the old readline() logic. The reason to mostly rely on readline is be