Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation

2020-07-10 Thread Corey Minyard
On Fri, Jul 10, 2020 at 11:53:13AM +0200, Philippe Mathieu-Daudé wrote: > Corey, this series is now fully reviewed :) Ok, I've pulled this in and added the extra reviews that came in. I'll work on getting it out Monday. Thanks, -corey > > On 7/6/20 12:41 AM, Philippe Mathieu-Daudé wrote: > >

Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation

2020-07-10 Thread Philippe Mathieu-Daudé
Corey, this series is now fully reviewed :) On 7/6/20 12:41 AM, Philippe Mathieu-Daudé wrote: > In commit d88c42ff2c we added 2 methods: i2c_try_create_slave() > and i2c_realize_and_unref(). > Markus noted their name could be improved for consistency [1], > and Peter reported the lack of documenta

[PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation

2020-07-05 Thread Philippe Mathieu-Daudé
In commit d88c42ff2c we added 2 methods: i2c_try_create_slave() and i2c_realize_and_unref(). Markus noted their name could be improved for consistency [1], and Peter reported the lack of documentation [2]. Fix that now. Since v1: - Addressed Markus review comments - Added Markus/Corey R-b tags [1