Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-17 Thread Stefano Garzarella
On Thu, Sep 17, 2020 at 01:00:08PM +0200, Cornelia Huck wrote: > On Thu, 17 Sep 2020 12:47:21 +0200 > Stefano Garzarella wrote: > > > Okay, so I'll leave the device property. > > > > > > I also need to update a series [1] that I sent to force virtio version 1 > > on vhost-vsock devices. > > Als

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-17 Thread Cornelia Huck
On Thu, 17 Sep 2020 12:47:21 +0200 Stefano Garzarella wrote: > Okay, so I'll leave the device property. > > > I also need to update a series [1] that I sent to force virtio version 1 > on vhost-vsock devices. > Also in this case I need to care about migration and force it only on new > machine

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-17 Thread Stefano Garzarella
On Thu, Sep 17, 2020 at 11:00:00AM +0100, Dr. David Alan Gilbert wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Thu, 17 Sep 2020 10:48:28 +0200 > > Stefano Garzarella wrote: > > > > > On Wed, Sep 16, 2020 at 11:08:48AM +0200, Cornelia Huck wrote: > > > > On Tue, 15 Sep 2020 15:05:14 +

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-17 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Thu, 17 Sep 2020 10:48:28 +0200 > Stefano Garzarella wrote: > > > On Wed, Sep 16, 2020 at 11:08:48AM +0200, Cornelia Huck wrote: > > > On Tue, 15 Sep 2020 15:05:14 +0200 > > > Stefano Garzarella wrote: > > > > > > > Commit 9b3a35ec82 ("virtio: v

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-17 Thread Cornelia Huck
On Thu, 17 Sep 2020 10:48:28 +0200 Stefano Garzarella wrote: > On Wed, Sep 16, 2020 at 11:08:48AM +0200, Cornelia Huck wrote: > > On Tue, 15 Sep 2020 15:05:14 +0200 > > Stefano Garzarella wrote: > > > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > > > on") ad

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-17 Thread Stefano Garzarella
On Wed, Sep 16, 2020 at 11:08:48AM +0200, Cornelia Huck wrote: > On Tue, 15 Sep 2020 15:05:14 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > > on") added a check that returns an error if legacy support is on, but the > > device

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-16 Thread Cornelia Huck
On Tue, 15 Sep 2020 15:05:14 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > on") added a check that returns an error if legacy support is on, but the > device is not legacy. > > Unfortunately some devices were wrongly declared legac

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-16 Thread Stefano Garzarella
+Cc qemu-sta...@nongnu.org It was not my day... I forgot to cc stable. Thanks, Stefano On Tue, Sep 15, 2020 at 03:05:14PM +0200, Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > on") added a check that returns an error if legacy support is

[PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-15 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a check that returns an error if legacy support is on, but the device is not legacy. Unfortunately some devices were wrongly declared legacy even if they were not (e.g vhost-vsock). To avoid migration issues, we