On Thu, 17 Sep 2020 12:47:21 +0200 Stefano Garzarella <sgarz...@redhat.com> wrote:
> Okay, so I'll leave the device property. > > > I also need to update a series [1] that I sent to force virtio version 1 > on vhost-vsock devices. > Also in this case I need to care about migration and force it only on new > machine types. > > Do you think I can reuse the same property also in vhost-vsock-pci and > vhost-vsock-ccw to force virtio version 1, or it is better to add a new > property for each device. > > The two things (disable legacy check and force version 1) are related, > so maybe I can use a single property in the virtio-device class, So, 'x-disable-legacy-check==false' -> 'we need to force version 1'? Seems reasonable to me. > > Thanks, > Stefano > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2020-08/msg04437.html >