Re: float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default)

2023-01-18 Thread Alex Bennée
Thomas Huth writes: > On 17/01/2023 11.44, Daniel P. Berrangé wrote: > ... >> And what i think is test float being overly verbose >>>> Testing f16_le_quiet >>46464 tests total. >> 1 >> 2 >> 3 >> 4 >>46464 tests performed. >> Could be written as >>

float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default)

2023-01-18 Thread Thomas Huth
On 17/01/2023 11.44, Daniel P. Berrangé wrote: ... And what i think is test float being overly verbose >> Testing f16_le_quiet 46464 tests total. 1 2 3 4 46464 tests performed. Could be written as >> Testing f16_le_quiet: 46464 tests total

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 01:55:49PM +0100, Thomas Huth wrote: > On 17/01/2023 11.44, Daniel P. Berrangé wrote: > > On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote: > ... > > > - Instead of doing "cat meson-logs/testlog.txt" in the CI > > >scripts, we switch to "tail -n 1000 meson-log

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-18 Thread Thomas Huth
On 17/01/2023 11.44, Daniel P. Berrangé wrote: On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote: ... - Instead of doing "cat meson-logs/testlog.txt" in the CI scripts, we switch to "tail -n 1000 meson-logs/testlog.txt" instead Tail requires that it has consumed the entire doc

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-17 Thread Peter Maydell
On Tue, 17 Jan 2023 at 12:02, Daniel P. Berrangé wrote: > > On Tue, Jan 17, 2023 at 11:16:32AM +, Peter Maydell wrote: > > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé > > wrote: > > > Something random that looks like bad text data > > > > > > ▶ 166/619 /ptimer/oneshot > > > policy=no_i

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-17 Thread Daniel P . Berrangé
On Tue, Jan 17, 2023 at 12:22:35PM +, Peter Maydell wrote: > On Tue, 17 Jan 2023 at 12:02, Daniel P. Berrangé wrote: > > > > On Tue, Jan 17, 2023 at 11:16:32AM +, Peter Maydell wrote: > > > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé > > > wrote: > > > > Something random that looks

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-17 Thread Daniel P . Berrangé
On Tue, Jan 17, 2023 at 11:16:32AM +, Peter Maydell wrote: > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé wrote: > > Something random that looks like bad text data > > > > ▶ 166/619 /ptimer/oneshot > > policy=no_immediate_...

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-17 Thread Peter Maydell
On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé wrote: > Something random that looks like bad text data > > ▶ 166/619 /ptimer/oneshot > policy=no_immediate_...snip� I don't understand this one. The string comes from

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-17 Thread Daniel P . Berrangé
On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote: > On 17/01/2023 11.23, Peter Maydell wrote: > > On Mon, 16 Jan 2023 at 16:55, Peter Maydell > > wrote: > > > > > > On Thu, 15 Dec 2022 at 15:30, Thomas Huth wrote: > > > > > > > > We're still running into the problem that some logs a

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-17 Thread Thomas Huth
On 17/01/2023 11.23, Peter Maydell wrote: On Mon, 16 Jan 2023 at 16:55, Peter Maydell wrote: On Thu, 15 Dec 2022 at 15:30, Thomas Huth wrote: We're still running into the problem that some logs are cut in the gitlab-CI since they got too big. The biggest part of the log is still the output

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-17 Thread Peter Maydell
On Mon, 16 Jan 2023 at 16:55, Peter Maydell wrote: > > On Thu, 15 Dec 2022 at 15:30, Thomas Huth wrote: > > > > We're still running into the problem that some logs are cut in the > > gitlab-CI since they got too big. The biggest part of the log is > > still the output of the qom-test. Let's stop

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-16 Thread Peter Maydell
On Thu, 15 Dec 2022 at 15:30, Thomas Huth wrote: > > We're still running into the problem that some logs are cut in the > gitlab-CI since they got too big. The biggest part of the log is > still the output of the qom-test. Let's stop printing the properties > by default to get to a saner size here

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-16 Thread Philippe Mathieu-Daudé
On 15/12/22 16:30, Thomas Huth wrote: We're still running into the problem that some logs are cut in the gitlab-CI since they got too big. The biggest part of the log is still the output of the qom-test. Let's stop printing the properties by default to get to a saner size here. The full output ca

[PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2022-12-15 Thread Thomas Huth
We're still running into the problem that some logs are cut in the gitlab-CI since they got too big. The biggest part of the log is still the output of the qom-test. Let's stop printing the properties by default to get to a saner size here. The full output can still be enabled by setting V=2 (or hi