Thomas Huth <th...@redhat.com> writes:
> On 17/01/2023 11.44, Daniel P. Berrangé wrote:
> ...
>> And what i think is test float being overly verbose
>> >> Testing f16_le_quiet
>> 46464 tests total.
>> 10000
>> 20000
>> 30000
>> 40000
>> 46464 tests performed.
>> Could be written as
>> >> Testing f16_le_quiet: 46464 tests total .... OK
>> (one '.' for each 10,000 tests run, before final 'OK' is printed)
>
> Unfortunately, the float tests are included via a git submodule, so
> the source code is not under our direct control here ... has anybody a
> good idea how to get this tackled best?
It is under our control. It is a lightly patched version of the
downstream testfloat package so we can patch it some more.
That said reducing 5 lines to one is hardly a massive reduction. If we
just stopped passing V=1 you would get:
➜ make check-softfloat
GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3
tests/fp/berkeley-softfloat-3 dtc roms/SLOF
[1/1] Generating qemu-version.h with a custom command (wrapped by meson to
capture output)
/usr/bin/python3 -B /home/alex/lsrc/qemu.git/meson/meson.py test --no-rebuild
-t 0 --num-processes 1 --print-errorlogs --suite softfloat
1/17 qemu:softfloat+softfloat-conv / fp-test-float-to-float OK
0.02s
2/17 qemu:softfloat+softfloat-conv / fp-test-int-to-float OK
0.01s
3/17 qemu:softfloat+softfloat-conv / fp-test-uint-to-float OK
0.01s
4/17 qemu:softfloat+softfloat-conv / fp-test-float-to-int OK
0.02s
5/17 qemu:softfloat+softfloat-conv / fp-test-float-to-uint OK
0.01s
6/17 qemu:softfloat+softfloat-conv / fp-test-round-to-integer OK
0.01s
7/17 qemu:softfloat+softfloat-compare / fp-test-eq_signaling OK
0.05s
8/17 qemu:softfloat+softfloat-compare / fp-test-le OK
0.05s
9/17 qemu:softfloat+softfloat-compare / fp-test-le_quiet OK
0.05s
10/17 qemu:softfloat+softfloat-compare / fp-test-lt_quiet OK
0.05s
11/17 qemu:softfloat+softfloat-ops / fp-test-add OK
0.58s
12/17 qemu:softfloat+softfloat-ops / fp-test-sub OK
0.59s
13/17 qemu:softfloat+softfloat-ops / fp-test-mul OK
2.83s
14/17 qemu:softfloat+softfloat-ops / fp-test-div OK
2.11s
15/17 qemu:softfloat+softfloat-ops / fp-test-rem OK
1.27s
16/17 qemu:softfloat+softfloat-ops / fp-test-sqrt OK
0.03s
17/17 qemu:softfloat+softfloat-ops / fp-test-log2 OK
0.02s
Ok: 17
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0
Full log written to /home/alex/lsrc/qemu.git/builds/all/meson-logs/testlog.txt
with the testlog being:
wc -l meson-logs/testlog.txt
2553 meson-logs/testlog.txt
>
> Thomas
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
