Re: [PATCH v2] target/riscv: don't read write-only CSR

2023-07-31 Thread Daniel Henrique Barboza
Patch looks correct IMHO. I have a few cosmetic suggestions: On 7/27/23 05:17, Nikita Shubin wrote: From: Nikita Shubin In case of write-only CSR don't return illegal inst error when CSR is written and lacks read op. It's worth citing the ISA bits you put down below in the commit msg. It w

[PATCH v2] target/riscv: don't read write-only CSR

2023-07-27 Thread Nikita Shubin
From: Nikita Shubin In case of write-only CSR don't return illegal inst error when CSR is written and lacks read op. Signed-off-by: Nikita Shubin --- Changelog: - fixed uninitialized old_value Anyway it not might be a good idea to read CSR when we are not asked for, during CSRRW or CSRRWI: "F