Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-09 Thread Philippe Mathieu-Daudé
On 8/9/21 11:33 AM, Qiang Liu wrote: > Thank you for all the insightful comments about the separated patches. > This would be my first time to format a serial of patches. Does it > look like below? > [PATCH v3 00/2] title > [PATCH v3 01/2] fix > [PATCH v3 02/2] test Exactly. Otherwise,

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-09 Thread Alexander Bulekov
On 210809 1131, Philippe Mathieu-Daudé wrote: > On 8/6/21 4:42 PM, Alexander Bulekov wrote: > > On 210804 1451, Qiang Liu wrote: > >> xlnx_dp_read allows an out-of-bounds read at its default branch because > >> of an improper index. > >> > >> According to > >> https://www.xilinx.com/html_docs/regis

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-09 Thread Qiang Liu
Thank you for all the insightful comments about the separated patches. This would be my first time to format a serial of patches. Does it look like below? [PATCH v3 00/2] title [PATCH v3 01/2] fix [PATCH v3 02/2] test Best, Qiang On Mon, Aug 9, 2021 at 11:24 AM Peter Maydell wrote: > >

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-09 Thread Philippe Mathieu-Daudé
On 8/6/21 4:42 PM, Alexander Bulekov wrote: > On 210804 1451, Qiang Liu wrote: >> xlnx_dp_read allows an out-of-bounds read at its default branch because >> of an improper index. >> >> According to >> https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html >> (DP Mod

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-09 Thread Peter Maydell
On Fri, 6 Aug 2021 at 15:43, Alexander Bulekov wrote: > As a side note(not strictly related to this fix) should we continue > joining reproducer patches with the fixes? In order to test the > reproducer, you need to cleave the fix off the patch. At the same time > we don't want to mess up bisectio

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-09 Thread Gerd Hoffmann
Hi, > As a side note(not strictly related to this fix) should we continue > joining reproducer patches with the fixes? In order to test the > reproducer, you need to cleave the fix off the patch. At the same time > we don't want to mess up bisection, so does it make sense to have the > reproduce

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Alexander Bulekov
On 210804 1451, Qiang Liu wrote: > xlnx_dp_read allows an out-of-bounds read at its default branch because > of an improper index. > > According to > https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html > (DP Module), registers 0x3A4/0x3A4/0x3AC are allowed. > >

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Thomas Huth
On 06/08/2021 09.00, Qiang Liu wrote: On Wed, Aug 4, 2021 at 3:43 PM Thomas Huth wrote: On 04/08/2021 08.51, Qiang Liu wrote: xlnx_dp_read allows an out-of-bounds read at its default branch because of an improper index. According to https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zy

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Qiang Liu
On Wed, Aug 4, 2021 at 3:43 PM Thomas Huth wrote: > > On 04/08/2021 08.51, Qiang Liu wrote: > > xlnx_dp_read allows an out-of-bounds read at its default branch because > > of an improper index. > > > > According to > > https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-regist

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-04 Thread Thomas Huth
On 04/08/2021 08.51, Qiang Liu wrote: xlnx_dp_read allows an out-of-bounds read at its default branch because of an improper index. According to https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html (DP Module), registers 0x3A4/0x3A4/0x3AC are allowed. DP_INT_M

[PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-03 Thread Qiang Liu
xlnx_dp_read allows an out-of-bounds read at its default branch because of an improper index. According to https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html (DP Module), registers 0x3A4/0x3A4/0x3AC are allowed. DP_INT_MASK 0x03A4 32 mixed