Re: [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Ninad Palsule
Hello Cedric, + +static void fsi_slave_reset(DeviceState *dev) +{ +    FSISlaveState *s = FSI_SLAVE(dev); +    int i; + +    /* Initialize registers */ +    for (i = 0; i < FSI_SLAVE_CONTROL_NR_REGS; i++) { +    s->regs[i] = 0; +    } memset would be better. Replaced for loop with memset

Re: [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers ap

[PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-25 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers appear in address space of the CFAM to whic