Re: [PATCH v1 37/59] s390x/event-facility.c: remove unneeded labels

2020-01-08 Thread Daniel Henrique Barboza
On 1/8/20 9:46 AM, Cornelia Huck wrote: On Mon, 6 Jan 2020 15:24:03 -0300 Daniel Henrique Barboza wrote: [..] I think read_event_data() is still a bit confusing, even if we get rid of the 'out:' label, as the flow remains the same. How about something like the following, which makes it

Re: [PATCH v1 37/59] s390x/event-facility.c: remove unneeded labels

2020-01-08 Thread Cornelia Huck
On Mon, 6 Jan 2020 15:24:03 -0300 Daniel Henrique Barboza wrote: > 'out' label from write_event_mask(), handle_sccb_read_events() > and write_event_data() can be replaced by 'return'. > > CC: Cornelia Huck > CC: Halil Pasic > CC: Christian Borntraeger > Signed-off-by: Daniel Henrique Barboza

Re: [PATCH v1 37/59] s390x/event-facility.c: remove unneeded labels

2020-01-07 Thread Thomas Huth
On 06/01/2020 19.24, Daniel Henrique Barboza wrote: > 'out' label from write_event_mask(), handle_sccb_read_events() > and write_event_data() can be replaced by 'return'. > > CC: Cornelia Huck > CC: Halil Pasic > CC: Christian Borntraeger > Signed-off-by: Daniel Henrique Barboza > --- > hw/s3

[PATCH v1 37/59] s390x/event-facility.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
'out' label from write_event_mask(), handle_sccb_read_events() and write_event_data() can be replaced by 'return'. CC: Cornelia Huck CC: Halil Pasic CC: Christian Borntraeger Signed-off-by: Daniel Henrique Barboza --- hw/s390x/event-facility.c | 21 ++--- 1 file changed, 6 ins