Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Wed, Oct 04, 2023 at 12:15:48PM +0200, Laszlo Ersek wrote: > On 10/3/23 17:55, Stefan Hajnoczi wrote: > > On Tue, 3 Oct 2023 at 10:41, Michael S. Tsirkin wrote: > >> > >> On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: > >>> (1) The virtio-1.0 specification > >>>

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/3/23 17:55, Stefan Hajnoczi wrote: > On Tue, 3 Oct 2023 at 10:41, Michael S. Tsirkin wrote: >> >> On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: >>> (1) The virtio-1.0 specification >>> writes: >>> 3 Gen

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/3/23 17:55, Stefan Hajnoczi wrote: > On Tue, 3 Oct 2023 at 10:41, Michael S. Tsirkin wrote: >> >> On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: >>> (1) The virtio-1.0 specification >>> writes: >>> 3 Gen

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 10:41, Michael S. Tsirkin wrote: > > On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: > > (1) The virtio-1.0 specification > > writes: > > > > > 3 General Initialization And Device Operation > >

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 10:40, Michael S. Tsirkin wrote: > > On Tue, Oct 03, 2023 at 09:08:15AM -0400, Stefan Hajnoczi wrote: > > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > > > > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > > > > One more question: > > > > >

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: > (1) The virtio-1.0 specification > writes: > > > 3 General Initialization And Device Operation > > 3.1 Device Initialization > > 3.1.1 Driver Requirements: Device

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, Oct 03, 2023 at 09:08:15AM -0400, Stefan Hajnoczi wrote: > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > > > One more question: > > > > > > Why is the disabled state not needed by regular (non-vhost) virtio

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 08:17:07PM -0400, Stefan Hajnoczi wrote: > On Mon, 2 Oct 2023 at 18:36, Michael S. Tsirkin wrote: > > > > On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > > > > > On Wed, Aug 30, 2023 at 1

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/3/23 16:25, Michael S. Tsirkin wrote: > On Tue, Oct 03, 2023 at 03:23:24PM +0200, Laszlo Ersek wrote: >> On 10/3/23 15:08, Stefan Hajnoczi wrote: >>> On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > One mo

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, Oct 03, 2023 at 03:23:24PM +0200, Laszlo Ersek wrote: > On 10/3/23 15:08, Stefan Hajnoczi wrote: > > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > >> > >> On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > >>> One more question: > >>> > >>> Why is the disabled st

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/3/23 15:08, Stefan Hajnoczi wrote: > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: >> >> On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: >>> One more question: >>> >>> Why is the disabled state not needed by regular (non-vhost) virtio-net >>> devices? >> >> Tap doe

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > > One more question: > > > > Why is the disabled state not needed by regular (non-vhost) virtio-net > > devices? > > Tap does the same - it purges queued packets: > > int

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > One more question: > > Why is the disabled state not needed by regular (non-vhost) virtio-net > devices? Tap does the same - it purges queued packets: int tap_disable(NetClientState *nc) { TAPState *s = DO_UPCAST(TAPState

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 18:36, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > > On Wed, 30 Aug 2023 at 09:30,

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > > > > > On 8/30/23 14:10, Stefan Hajno

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

One more question: Why is the disabled state not needed by regular (non-vhost) virtio-net devices? On Mon, 2 Oct 2023 at 17:12, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > On Wed

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > > > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > > > >

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/2/23 08:57, Michael S. Tsirkin wrote: > On Mon, Oct 02, 2023 at 03:56:03AM +0200, Laszlo Ersek wrote: >> On 10/1/23 21:25, Michael S. Tsirkin wrote: >>> Not this actually - v2 of this. >> >> Thank you, but: >> >> - Stefan's question should be answered still IMO (although if you pick >> up thi

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 03:56:03AM +0200, Laszlo Ersek wrote: > On 10/1/23 21:25, Michael S. Tsirkin wrote: > > Not this actually - v2 of this. > > Thank you, but: > > - Stefan's question should be answered still IMO (although if you pick > up this series, then that could be interpreted as "QEMU

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > > >> > > >> (1) The virtio-1.0 specification > > >>

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/1/23 21:25, Michael S. Tsirkin wrote: > Not this actually - v2 of this. Thank you, but: - Stefan's question should be answered still IMO (although if you pick up this series, then that could be interpreted as "QEMU bug, not spec bug") - I was supposed to update the commit message on 7/7 in

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

Not this actually - v2 of this. On Sun, Oct 01, 2023 at 03:24:59PM -0400, Michael S. Tsirkin wrote: > yes sorry - I am working on a pull request with this > included. > > On Mon, Sep 25, 2023 at 05:31:17PM +0200, Laszlo Ersek wrote: > > Ping -- Michael, any comments please? This set (now at v2) h

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

yes sorry - I am working on a pull request with this included. On Mon, Sep 25, 2023 at 05:31:17PM +0200, Laszlo Ersek wrote: > Ping -- Michael, any comments please? This set (now at v2) has been > waiting on your answer since Aug 30th. > > Laszlo > > On 9/5/23 08:30, Laszlo Ersek wrote: > > Mich

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

Ping -- Michael, any comments please? This set (now at v2) has been waiting on your answer since Aug 30th. Laszlo On 9/5/23 08:30, Laszlo Ersek wrote: > Michael, > > On 8/30/23 17:37, Stefan Hajnoczi wrote: >> On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: >>> >>> On 8/30/23 14:10, Stefan Ha

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

Michael, On 8/30/23 17:37, Stefan Hajnoczi wrote: > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: >> >> On 8/30/23 14:10, Stefan Hajnoczi wrote: >>> On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: (1) The virtio-1.0 specification

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > >> > >> (1) The virtio-1.0 specification > >> writes: > >> > >>> 3 General In

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Wed, Aug 30, 2023 at 11:26:41AM +0200, Laszlo Ersek wrote: On 8/30/23 10:39, Stefano Garzarella wrote: On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: (1) The virtio-1.0 specification writes: What about referrin

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 8/30/23 14:10, Stefan Hajnoczi wrote: > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: >> >> (1) The virtio-1.0 specification >> writes: >> >>> 3 General Initialization And Device Operation >>> 3.1 Device Initialization >

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > > (1) The virtio-1.0 specification > writes: > > > 3 General Initialization And Device Operation > > 3.1 Device Initialization > > 3.1.1 Driver Requirements: Device Initializa

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 8/30/23 10:39, Stefano Garzarella wrote: > On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: >> (1) The virtio-1.0 specification >> writes: > > What about referring the latest spec available now (1.2)? I didn't want t

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 8/30/23 10:59, Laszlo Ersek wrote: > On 8/30/23 10:41, Laszlo Ersek wrote: >> I'm adding Stefan to the CC list, and an additional piece of explanation >> below: >> >> On 8/27/23 20:29, Laszlo Ersek wrote: >>> (1) The virtio-1.0 specification >>>

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 8/30/23 10:41, Laszlo Ersek wrote: > I'm adding Stefan to the CC list, and an additional piece of explanation > below: > > On 8/27/23 20:29, Laszlo Ersek wrote: >> (1) The virtio-1.0 specification >> writes: >> >>> 3 General I

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

I'm adding Stefan to the CC list, and an additional piece of explanation below: On 8/27/23 20:29, Laszlo Ersek wrote: > (1) The virtio-1.0 specification > writes: > >> 3 General Initialization And Device Operation >> 3.1 Devic

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: (1) The virtio-1.0 specification writes: What about referring the latest spec available now (1.2)? 3 General Initialization And Device Operation 3.1 Device In

[PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

(1) The virtio-1.0 specification writes: > 3 General Initialization And Device Operation > 3.1 Device Initialization > 3.1.1 Driver Requirements: Device Initialization > > [...] > > 7. Perform device-specific setup, including d