Re: [PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerators

2021-03-15 Thread Philippe Mathieu-Daudé
On 3/15/21 2:52 PM, Claudio Fontana wrote: > On 1/21/21 7:06 AM, Richard Henderson wrote: >> On 1/17/21 11:12 PM, Claudio Fontana wrote: >>> On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: tb_gen_code() is only called within TCG accelerator, declare it locally. >>> >>> Is this used only

Re: [PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerators

2021-03-15 Thread Claudio Fontana
On 1/21/21 7:06 AM, Richard Henderson wrote: > On 1/17/21 11:12 PM, Claudio Fontana wrote: >> On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: >>> tb_gen_code() is only called within TCG accelerator, >>> declare it locally. >> >> Is this used only in accel/tcg/cpu-exec.c ? Should it be a static fu

Re: [PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerators

2021-01-20 Thread Richard Henderson
On 1/17/21 11:12 PM, Claudio Fontana wrote: > On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: >> tb_gen_code() is only called within TCG accelerator, >> declare it locally. > > Is this used only in accel/tcg/cpu-exec.c ? Should it be a static function > there? Possibly, but there's a *lot* of

Re: [PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerators

2021-01-18 Thread Claudio Fontana
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: > tb_gen_code() is only called within TCG accelerator, > declare it locally. Is this used only in accel/tcg/cpu-exec.c ? Should it be a static function there? Ciao, Claudio > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/tcg/internal

[PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerators

2021-01-17 Thread Philippe Mathieu-Daudé
tb_gen_code() is only called within TCG accelerator, declare it locally. Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/internal.h| 5 + include/exec/exec-all.h | 5 - accel/tcg/cpu-exec.c| 1 + accel/tcg/user-exec.c | 1 + 4 files changed, 7 insertions(+), 5 deletions(-)