On 1/17/21 11:12 PM, Claudio Fontana wrote: > On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: >> tb_gen_code() is only called within TCG accelerator, >> declare it locally. > > Is this used only in accel/tcg/cpu-exec.c ? Should it be a static function > there?
Possibly, but there's a *lot* of code that would have to be moved. For now, queuing a slightly modified version of the patch. >> --- a/accel/tcg/user-exec.c >> +++ b/accel/tcg/user-exec.c >> @@ -28,6 +28,7 @@ >> #include "qemu/atomic128.h" >> #include "trace/trace-root.h" >> #include "trace/mem.h" >> +#include "internal.h" Not needed by this patch. r~
