Re: [PATCH 21/71] target/arm: Implement TPIDR2_EL0

2022-06-06 Thread Richard Henderson
On 6/6/22 06:18, Peter Maydell wrote: +if (!(sctlr & SCTLR_EnTP2)) { +uint64_t hcr = arm_hcr_el2_eff(env); +return hcr & HCR_TGE ? CP_ACCESS_TRAP_EL2 : CP_ACCESS_TRAP; Do we really need to do this rather than just returning CP_ACCESS_TRAP and letting the "take tr

Re: [PATCH 21/71] target/arm: Implement TPIDR2_EL0

2022-06-06 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:11, Richard Henderson wrote: > > This register is part of SME, but isn't closely related to the > rest of the extension. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h| 1 + > target/arm/helper.c | 32 > 2 files change

[PATCH 21/71] target/arm: Implement TPIDR2_EL0

2022-06-02 Thread Richard Henderson
This register is part of SME, but isn't closely related to the rest of the extension. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 1 + target/arm/helper.c | 32 2 files changed, 33 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h in