Re: [PATCH 2/2] target/riscv: Include missing headers in 'internals.h'

2024-12-03 Thread Alistair Francis
On Wed, Dec 4, 2024 at 5:09 AM Philippe Mathieu-Daudé wrote: > > Rather than relying on implicit includes, explicit them, > in order to avoid when refactoring unrelated headers: > > target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S' > 49 | ret = PRV_S; >

Re: [PATCH 2/2] target/riscv: Include missing headers in 'internals.h'

2024-12-03 Thread Daniel Henrique Barboza
On 12/3/24 5:08 PM, Philippe Mathieu-Daudé wrote: Rather than relying on implicit includes, explicit them, in order to avoid when refactoring unrelated headers: target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S' 49 | ret = PRV_S; |

[PATCH 2/2] target/riscv: Include missing headers in 'internals.h'

2024-12-03 Thread Philippe Mathieu-Daudé
Rather than relying on implicit includes, explicit them, in order to avoid when refactoring unrelated headers: target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S' 49 | ret = PRV_S; | ^ target/riscv/internals.h:93:9: error: call to unde