On Wed, Dec 4, 2024 at 5:09 AM Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > Rather than relying on implicit includes, explicit them, > in order to avoid when refactoring unrelated headers: > > target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S' > 49 | ret = PRV_S; > | ^ > target/riscv/internals.h:93:9: error: call to undeclared function > 'env_archcpu'; ISO C99 and later do not support implicit function > declarations [-Wimplicit-function-declaration] > 93 | if (env_archcpu(env)->cfg.ext_zfinx) { > | ^ > target/riscv/internals.h:101:15: error: unknown type name 'float32'; did > you mean 'float'? > 101 | static inline float32 check_nanbox_s(CPURISCVState *env, uint64_t f) > | ^~~~~~~ > | float > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Alistair > --- > target/riscv/internals.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target/riscv/internals.h b/target/riscv/internals.h > index ddbdee885bc..76934eaa7b5 100644 > --- a/target/riscv/internals.h > +++ b/target/riscv/internals.h > @@ -19,7 +19,10 @@ > #ifndef RISCV_CPU_INTERNALS_H > #define RISCV_CPU_INTERNALS_H > > +#include "exec/cpu-common.h" > #include "hw/registerfields.h" > +#include "fpu/softfloat-types.h" > +#include "target/riscv/cpu_bits.h" > > /* > * The current MMU Modes are: > -- > 2.45.2 > >