Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-10 Thread Peter Xu
On Tue, Jun 10, 2025 at 05:55:31PM -0300, Fabiano Rosas wrote: > I think I caused some confusion here. I wrote migrate_params_override() > last thing on a friday and forgot it did the right thing from the > beginning: > > migrate_params_apply(&s->defaults); > qmp_migrate_set_parameters(new

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-10 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 09, 2025 at 04:41:06PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Jun 09, 2025 at 03:02:06PM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: >> >> >> Peter Xu w

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
On Mon, Jun 09, 2025 at 04:41:06PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Jun 09, 2025 at 03:02:06PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: > >> >> Peter Xu writes: > >> >> > >> >> > On

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 09, 2025 at 03:02:06PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: >> >> >> Peter Xu w

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
On Mon, Jun 09, 2025 at 03:02:06PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: > >> >> Peter Xu writes: > >> >> > >> >> > On

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Fabiano Rosas
Peter Xu writes: > (I had a reply in the other thread, that might have covered most of the > points but maybe not this one..) > > On Mon, Jun 09, 2025 at 05:13:00PM +0100, Daniel P. Berrangé wrote: >> Even if only a single mgmt app is involved this is still beneficial >> because the migration in

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: >> >> >> Allow the m

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
(I had a reply in the other thread, that might have covered most of the points but maybe not this one..) On Mon, Jun 09, 2025 at 05:13:00PM +0100, Daniel P. Berrangé wrote: > Even if only a single mgmt app is involved this is still beneficial > because the migration infrastructure is used for dis

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
On Mon, Jun 09, 2025 at 05:15:43PM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 09, 2025 at 11:53:47AM -0400, Peter Xu wrote: > > On Mon, Jun 09, 2025 at 04:43:40PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jun 09, 2025 at 11:33:14AM -0400, Peter Xu wrote: > > > > > > > > Now I think I know

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Daniel P . Berrangé
On Mon, Jun 09, 2025 at 11:53:47AM -0400, Peter Xu wrote: > On Mon, Jun 09, 2025 at 04:43:40PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 09, 2025 at 11:33:14AM -0400, Peter Xu wrote: > > > > > > Now I think I know part of what I've missed: I used to think the "config" > > > of per-QMP-migra

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Daniel P . Berrangé
On Mon, Jun 09, 2025 at 11:51:17AM -0400, Peter Xu wrote: > On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: > > >> Peter Xu writes: > > >> > > >> > On Mon, Jun 02, 2025 at 10:38:08PM -03

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
On Mon, Jun 09, 2025 at 11:53:47AM -0400, Peter Xu wrote: > On Mon, Jun 09, 2025 at 04:43:40PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 09, 2025 at 11:33:14AM -0400, Peter Xu wrote: > > > > > > Now I think I know part of what I've missed: I used to think the "config" > > > of per-QMP-migra

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
On Mon, Jun 09, 2025 at 04:43:40PM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 09, 2025 at 11:33:14AM -0400, Peter Xu wrote: > > > > Now I think I know part of what I've missed: I used to think the "config" > > of per-QMP-migrate-command can be totally temporary for a specific > > migration req

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: > >> >> Allow the migrate and migrate_incoming

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Daniel P . Berrangé
On Mon, Jun 09, 2025 at 11:33:14AM -0400, Peter Xu wrote: > > Now I think I know part of what I've missed: I used to think the "config" > of per-QMP-migrate-command can be totally temporary for a specific > migration request, but then we need another MigrationState.parameters_2 to > cache the old

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Peter Xu
On Mon, Jun 09, 2025 at 04:03:01PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 06, 2025 at 04:50:54PM -0400, Peter Xu wrote: > > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: > > > Peter Xu writes: > > > > > > > On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: >

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Daniel P . Berrangé
On Fri, Jun 06, 2025 at 04:50:54PM -0400, Peter Xu wrote: > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: > > >> Allow the migrate and migrate_incoming commands to pass the migration > >

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-09 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: >> >> Allow the migrate and migrate_incoming commands to pass the migration >> >> configuration options all at once, dispe

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-06 Thread Peter Xu
On Fri, Jun 06, 2025 at 05:23:18PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: > >> Allow the migrate and migrate_incoming commands to pass the migration > >> configuration options all at once, dispensing the use of > >> migr

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-06 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: >> Allow the migrate and migrate_incoming commands to pass the migration >> configuration options all at once, dispensing the use of >> migrate-set-parameters and migrate-set-capabilities. >> >> The motivation of t

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-06 Thread Peter Xu
On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: > Allow the migrate and migrate_incoming commands to pass the migration > configuration options all at once, dispensing the use of > migrate-set-parameters and migrate-set-capabilities. > > The motivation of this is to simplify the int

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-03 Thread Daniel P . Berrangé
On Mon, Jun 02, 2025 at 10:38:08PM -0300, Fabiano Rosas wrote: > Allow the migrate and migrate_incoming commands to pass the migration > configuration options all at once, dispensing the use of > migrate-set-parameters and migrate-set-capabilities. > > The motivation of this is to simplify the int

[PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-02 Thread Fabiano Rosas
Allow the migrate and migrate_incoming commands to pass the migration configuration options all at once, dispensing the use of migrate-set-parameters and migrate-set-capabilities. The motivation of this is to simplify the interface with the management layer and avoid the usage of several command i