Re: [PATCH 10/25] target/i386: finish converting 0F AE to the new decoder

2024-10-21 Thread Guenter Roeck
On 10/20/24 23:57, Paolo Bonzini wrote: On 10/21/24 03:49, Guenter Roeck wrote: Hi, On Sat, Jun 08, 2024 at 10:40:58AM +0200, Paolo Bonzini wrote: This is already partly implemented due to VLDMXCSR and VSTMXCSR; finish the job. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson W

Re: [PATCH 10/25] target/i386: finish converting 0F AE to the new decoder

2024-10-20 Thread Paolo Bonzini
On 10/21/24 03:49, Guenter Roeck wrote: Hi, On Sat, Jun 08, 2024 at 10:40:58AM +0200, Paolo Bonzini wrote: This is already partly implemented due to VLDMXCSR and VSTMXCSR; finish the job. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson While testing qemu v9.1, I noticed the fol

Re: [PATCH 10/25] target/i386: finish converting 0F AE to the new decoder

2024-10-20 Thread Guenter Roeck
Hi, On Sat, Jun 08, 2024 at 10:40:58AM +0200, Paolo Bonzini wrote: > This is already partly implemented due to VLDMXCSR and VSTMXCSR; finish > the job. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Richard Henderson While testing qemu v9.1, I noticed the following crash when testing qemu-sy

Re: [PATCH 10/25] target/i386: finish converting 0F AE to the new decoder

2024-06-08 Thread Richard Henderson
On 6/8/24 01:40, Paolo Bonzini wrote: +static void gen_FXRSTOR(DisasContext *s, X86DecodedInsn *decode) +{ +if ((s->flags & HF_EM_MASK) || (s->flags & HF_TS_MASK)) { +gen_NM_exception(s); +} +gen_helper_fxrstor(tcg_env, s->A0); +} + +static void gen_FXSAVE(DisasContext *s, X86

[PATCH 10/25] target/i386: finish converting 0F AE to the new decoder

2024-06-08 Thread Paolo Bonzini
This is already partly implemented due to VLDMXCSR and VSTMXCSR; finish the job. Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.h | 7 ++ target/i386/tcg/translate.c | 188 --- target/i386/tcg/decode-new.c.inc | 48 +++- target/i386/tcg/em